Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add linter rules, update github actions #8

Merged
merged 5 commits into from
Feb 19, 2024
Merged

add linter rules, update github actions #8

merged 5 commits into from
Feb 19, 2024

Conversation

miparnisari
Copy link
Contributor

No description provided.

@miparnisari miparnisari marked this pull request as ready for review February 17, 2024 19:35
janos
janos requested changes Feb 17, 2024
View reviewed changes
Copy link
Owner

@janos janos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Maria, thank you so much for these improvements. I have a few comments, but this PR is very much welcomed.

.github/workflows/go.yml Outdated Show resolved Hide resolved
.golangci.yaml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@miparnisari miparnisari requested a review from janos February 17, 2024 21:10
@miparnisari miparnisari changed the title add makefile, add linter rules, update github actions add linter rules, update github actions Feb 19, 2024
janos
janos approved these changes Feb 19, 2024
View reviewed changes
Copy link
Owner

@janos janos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @miparnisari!

@janos janos merged commit bfebb53 into janos:master Feb 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janos janos janos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miparnisari @janos